Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(smoke): improve smoke test steps and reduce node_modules cleanup #2548

Closed
wants to merge 2 commits into from
Closed

test(smoke): improve smoke test steps and reduce node_modules cleanup #2548

wants to merge 2 commits into from
+1,211 −941

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Smoke Test Improvements

This PR improves the smoke test reliability and Node.js version handling:

  • Add exact Node.js 23.3.0 version check
  • Improve server startup detection with port detection
  • Add status endpoint check
  • Reduce unnecessary node_modules cleanup
  • Add DISABLE_PLUGINS support for minimal testing
  • Handle bs58 compatibility issues

Link to Devin run: https://app.devin.ai/sessions/932bde6dca444a9f8f00acf5f1d2f803

@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@wtfsayo wtfsayo closed this Jan 20, 2025
@shakkernerd shakkernerd deleted the devin/1737366160-improve-smoke-tests branch January 31, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wtfsayo